refactor: http and route #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
把Gin移除以后Auth包那边的测试没法运行了，缺少 cc @hwbrzzl. |
|
将 Auth 的测试与 Route/Http 解耦吧？如果需要，Auth 直接使用 net/http 发起请求。 |
# Conflicts: # go.mod # go.sum # http/gin_request.go # http/gin_response.go # http/service_provider.go # route/gin_test.go
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #198 +/- ##
==========================================
+ Coverage 63.46% 65.36% +1.90%
==========================================
Files 145 136 -9
Lines 9023 8423 -600
==========================================
- Hits 5726 5506 -220
+ Misses 2907 2532 -375
+ Partials 390 385 -5
☔ View full report in Codecov by Sentry. |
devhaozi
added
🚀 Review Ready
❗ Breaking Change
and removed
🛠 In Progress
💡 Need Help
labels
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
hwbrzzl
reviewed
Jul 1, 2023
1 task
Maybe it can't be done because can't register routes. I'm going to try to fallback to the original way. |
This reverts commit bdc55fe.
hwbrzzl
reviewed
Aug 11, 2023
|
Sorry, I saw the configuration in goravel/gin. |
|
FYI, I'm testing goravel/http-middleware. |
kkumar-gcc
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes goravel/goravel#206
Closes goravel/goravel#93
Closes goravel/goravel#187
📑 Description
Refactor http and route.
✅ Checks
ℹ Additional Information
none.