Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add factory functionality #235

Merged
merged 23 commits into from
Jul 17, 2023
Merged

feat: add factory functionality #235

merged 23 commits into from
Jul 17, 2023

Conversation

kkumar-gcc
Copy link
Member

@kkumar-gcc kkumar-gcc commented Jul 7, 2023

Closes goravel/goravel#201

πŸ“‘ Description

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great first step! πŸ‘

database/console/factory_make_command.go Outdated Show resolved Hide resolved
contracts/database/orm/factory.go Show resolved Hide resolved
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good first step! πŸ‘

contracts/database/orm/factory.go Outdated Show resolved Hide resolved
contracts/database/orm/factory.go Outdated Show resolved Hide resolved
database/gorm/factory.go Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: Need to update the orm mock.

contracts/database/orm/factory.go Outdated Show resolved Hide resolved
contracts/database/orm/factory.go Outdated Show resolved Hide resolved
database/gorm/factory.go Outdated Show resolved Hide resolved
contracts/database/orm/factory.go Outdated Show resolved Hide resolved
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better, we can add some unit tests now. πŸ‘

database/gorm/factory.go Outdated Show resolved Hide resolved
database/gorm/factory.go Show resolved Hide resolved
database/gorm/factory.go Outdated Show resolved Hide resolved
database/gorm/factory.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch coverage: 73.71% and project coverage change: +0.65 πŸŽ‰

Comparison is base (989ae8b) 62.76% compared to head (c374462) 63.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #235      +/-   ##
==========================================
+ Coverage   62.76%   63.41%   +0.65%     
==========================================
  Files         128      132       +4     
  Lines        8314     8531     +217     
==========================================
+ Hits         5218     5410     +192     
- Misses       2735     2742       +7     
- Partials      361      379      +18     
Impacted Files Coverage Ξ”
config/service_provider.go 0.00% <0.00%> (ΓΈ)
database/service_provider.go 0.00% <0.00%> (ΓΈ)
route/utils.go 79.03% <ΓΈ> (-1.28%) ⬇️
schedule/service_provider.go 0.00% <0.00%> (ΓΈ)
support/database/database.go 79.31% <0.00%> (ΓΈ)
config/application.go 44.44% <20.00%> (-0.77%) ⬇️
crypt/aes.go 52.77% <33.33%> (-0.65%) ⬇️
http/console/controller_make_command.go 70.96% <42.85%> (-6.59%) ⬇️
foundation/application.go 62.83% <46.15%> (-0.28%) ⬇️
contracts/foundation/service_provider.go 50.00% <50.00%> (ΓΈ)
... and 13 more

... and 1 file with indirect coverage changes

β˜” View full report in Codecov by Sentry.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@kkumar-gcc kkumar-gcc requested a review from hwbrzzl July 14, 2023 11:24
database/gorm/factory.go Outdated Show resolved Hide resolved
database/gorm/factory.go Outdated Show resolved Hide resolved
database/gorm/factory_test.go Show resolved Hide resolved
database/gorm/factory_test.go Outdated Show resolved Hide resolved
database/gorm/factory_test.go Outdated Show resolved Hide resolved
database/gorm/factory_test.go Outdated Show resolved Hide resolved
database/gorm/factory_test.go Show resolved Hide resolved
database/gorm/factory_test.go Outdated Show resolved Hide resolved
database/gorm/factory_test.go Outdated Show resolved Hide resolved
database/gorm/factory.go Outdated Show resolved Hide resolved
database/gorm/factory.go Outdated Show resolved Hide resolved
database/gorm/test_utils.go Outdated Show resolved Hide resolved
@kkumar-gcc kkumar-gcc requested a review from hwbrzzl July 17, 2023 08:14
database/gorm/factory_test.go Outdated Show resolved Hide resolved
database/gorm/factory_test.go Outdated Show resolved Hide resolved
@kkumar-gcc kkumar-gcc requested a review from hwbrzzl July 17, 2023 09:04
database/console/stubs.go Outdated Show resolved Hide resolved
database/gorm/factory_test.go Outdated Show resolved Hide resolved
contracts/database/factory/factory.go Outdated Show resolved Hide resolved
database/gorm/factory_test.go Outdated Show resolved Hide resolved
@kkumar-gcc kkumar-gcc requested a review from hwbrzzl July 17, 2023 10:26
hwbrzzl
hwbrzzl previously approved these changes Jul 17, 2023
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, Bro!

auto-merge was automatically disabled July 17, 2023 10:35

Head branch was pushed to by a user without write access

@kkumar-gcc kkumar-gcc requested a review from hwbrzzl July 17, 2023 10:44
@hwbrzzl hwbrzzl merged commit 6ce8647 into goravel:master Jul 17, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature] Add Factories Module
2 participants