Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: facades.Orm supports sum #241

Merged
merged 4 commits into from
Jul 19, 2023
Merged

feat: facades.Orm supports sum #241

merged 4 commits into from
Jul 19, 2023

Conversation

kkumar-gcc
Copy link
Member

@kkumar-gcc kkumar-gcc commented Jul 19, 2023 •
edited
Loading

Closes goravel/goravel#95

📑 Description

This PR will add Sum method in query to calculate the sum of values in a specific column(only numeric columns).

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

@kkumar-gcc kkumar-gcc changed the title Kkumar gcc/#95 feat: facades.Orm supports cursor and sum Jul 19, 2023
hwbrzzl
hwbrzzl reviewed Jul 19, 2023
View reviewed changes
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, Bro. There is no problem in the code, but CI failed, and please add the Review Ready label when the PR can be reviewed.
image

hwbrzzl
hwbrzzl approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hwbrzzl hwbrzzl changed the title feat: facades.Orm supports cursor and sum feat: facades.Orm supports sum Jul 19, 2023
@hwbrzzl hwbrzzl merged commit c9ca5dc into master Jul 19, 2023
11 checks passed
@hwbrzzl hwbrzzl deleted the kkumar-gcc/#95 branch July 19, 2023 13:58
kkumar-gcc added a commit that referenced this pull request May 30, 2024
@kkumar-gcc
Merge branch 'master' into kkumar-gcc/#241
69931f3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwbrzzl hwbrzzl hwbrzzl approved these changes

Assignees
No one assigned
Labels
🚀 Review Ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ [Feature] facades.Orm supports cursor and sum
2 participants
@kkumar-gcc @hwbrzzl