Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: facades.Orm supports cursor #243

Merged
merged 4 commits into from
Jul 24, 2023
Merged

feat: facades.Orm supports cursor #243

merged 4 commits into from
Jul 24, 2023

Conversation

kkumar-gcc
Copy link
Member

Closes goravel/goravel#95

📑 Description

This PR adds support for the Cursor method in the query, enabling efficient handling of large result sets without loading all data into memory.

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

@kkumar-gcc kkumar-gcc changed the title feat: facades.Orm supports cursor feat: facades.Orm supports cursor Jul 21, 2023
hwbrzzl
hwbrzzl reviewed Jul 21, 2023
View reviewed changes
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, bro, that's what we want. Please add some test cases after I solve the timestamp problem in mapstructure, then this's PR can be merged.

database/gorm/query.go Outdated Show resolved Hide resolved
database/gorm/query.go Outdated Show resolved Hide resolved
database/gorm/query.go Outdated Show resolved Hide resolved
@kkumar-gcc kkumar-gcc requested a review from hwbrzzl July 24, 2023 06:42
hwbrzzl
hwbrzzl reviewed Jul 24, 2023
View reviewed changes
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍

database/gorm/query.go Outdated Show resolved Hide resolved
database/gorm/query_test.go Show resolved Hide resolved
@kkumar-gcc kkumar-gcc requested a review from hwbrzzl July 24, 2023 10:35
hwbrzzl
hwbrzzl approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hwbrzzl hwbrzzl enabled auto-merge (squash) July 24, 2023 10:42
@hwbrzzl hwbrzzl merged commit 70a2d7f into master Jul 24, 2023
10 of 11 checks passed
@hwbrzzl hwbrzzl deleted the kkumar-gcc/#95 branch July 24, 2023 11:05
hwbrzzl added a commit that referenced this pull request Sep 3, 2023
@hwbrzzl
feat: [#243] Optimize the return of controller
4dd5ee8
hwbrzzl added a commit that referenced this pull request Sep 5, 2023
@hwbrzzl
feat: [#243] Optimize the return of controller (#284)
6548378 
* feat: [#243] Optimize the return of controller

* Fix conflict

* Fix conflict

* Optimize unit tests

* Optimize unit tests

* Optimize unit tests

* Test case

* Test

* Test

* Cancel test
hwbrzzl added a commit that referenced this pull request Sep 6, 2023
@hwbrzzl
feat: [#243] Optimize Response.Render return
bcf702d
hwbrzzl added a commit that referenced this pull request Sep 6, 2023
@hwbrzzl
feat: [#243] Optimize Response.Render return (#289)
41bdad4 
* feat: [#243] Optimize Response.Render return

* Optimize mock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwbrzzl hwbrzzl hwbrzzl approved these changes

Assignees
No one assigned
Labels
🚀 Review Ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ [Feature] facades.Orm supports cursor and sum
2 participants
@kkumar-gcc @hwbrzzl