feat: optimize schedule #657

hwbrzzl · 2024-09-26T11:10:26Z

📑 Description

Optimize the test speed, the schedule will spend 5 minutes before, after this optimization, only about 1.5 minute;
Add the Stop method for Schedule, User can use the method to stop Schedule gracefully;
For test purpose, add implicit second crontab support, User can also use it by .Cron("* * * * * *"), the default is * * * * *;

@coderabbitai summary

✅ Checks

Added test cases for my code

coderabbitai · 2024-09-26T11:10:31Z

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

📥 Commits

Files that changed from the base of the PR and between cb355db and 1b9b552.

⛔ Files ignored due to path filters (2)

mocks/route/Route.go is excluded by !mocks/**
mocks/schedule/Schedule.go is excluded by !mocks/**

📒 Files selected for processing (6)

contracts/route/route.go (1 hunks)
contracts/schedule/schedule.go (2 hunks)
schedule/application.go (3 hunks)
schedule/application_test.go (3 hunks)
schedule/event.go (1 hunks)
schedule/event_test.go (1 hunks)

________________________________________
< My other transformer is Optimus Prime. >
----------------------------------------
 \
  \   \
       \ /\
       ( )
     .( o ).

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.

Benchmark suite	Current: `1b9b552`	Previous: `cb355db`	Ratio
`Benchmark_DecryptString`	`4904` ns/op 1592 B/op 17 allocs/op	`1945` ns/op 1592 B/op 17 allocs/op	`2.52`
`Benchmark_DecryptString - ns/op`	`4904` ns/op	`1945` ns/op	`2.52`
`BenchmarkFile_ReadWrite`	`380169` ns/op 1800 B/op 21 allocs/op	`228413` ns/op 1800 B/op 21 allocs/op	`1.66`
`BenchmarkFile_ReadWrite - ns/op`	`380169` ns/op	`228413` ns/op	`1.66`

This comment was automatically generated by workflow using github-action-benchmark.

github-actions

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.

Benchmark suite	Current: `e38a94d`	Previous: `cb355db`	Ratio
`Benchmark_Fatal`	`2e-7` ns/op 0 B/op 0 allocs/op	`1e-7` ns/op 0 B/op 0 allocs/op	`2`
`Benchmark_Fatal - ns/op`	`2e-7` ns/op	`1e-7` ns/op	`2`

This comment was automatically generated by workflow using github-action-benchmark.

codecov · 2024-09-26T11:22:03Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.49%. Comparing base (cb355db) to head (1b9b552).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #657      +/-   ##
==========================================
+ Coverage   70.45%   70.49%   +0.03%     
==========================================
  Files         188      188              
  Lines       11675    11689      +14     
==========================================
+ Hits         8226     8240      +14     
  Misses       2860     2860              
  Partials      589      589

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hwbrzzl · 2024-09-26T11:13:01Z

contracts/route/route.go

 	Shutdown(ctx ...context.Context) error
+	// Stop gracefully stop the serve.
+	Stop(ctx ...context.Context) error


Keep consistence with Schedule.

hwbrzzl · 2024-09-26T11:13:44Z

schedule/application.go

-		log:     log,
-		debug:   debug,
+		cron: cron.New(cron.WithParser(cron.NewParser(
+			cron.SecondOptional|cron.Minute|cron.Hour|cron.Dom|cron.Month|cron.Dow|cron.Descriptor,


The document: https://github.com/robfig/cron?tab=readme-ov-file#upgrading-to-v3-june-2019

devhaozi

LGTM

feat: optimize schedule

e38a94d

Merge branch 'master' into bowen/optimize-schedule-test

b6c5d97

github-actions bot reviewed Sep 26, 2024

View reviewed changes

fix test

1b9b552

hwbrzzl commented Sep 26, 2024

View reviewed changes

hwbrzzl marked this pull request as ready for review September 26, 2024 11:24

hwbrzzl requested a review from a team as a code owner September 26, 2024 11:24

hwbrzzl added the 🚀 Review Ready label Sep 26, 2024

devhaozi approved these changes Sep 27, 2024

View reviewed changes

hwbrzzl merged commit d23da62 into master Sep 27, 2024
10 of 12 checks passed

hwbrzzl deleted the bowen/optimize-schedule-test branch September 27, 2024 15:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: optimize schedule #657

feat: optimize schedule #657

hwbrzzl commented Sep 26, 2024 •

edited

Loading

coderabbitai bot commented Sep 26, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

github-actions bot left a comment •

edited

Loading

github-actions bot left a comment

codecov bot commented Sep 26, 2024 •

edited

Loading

hwbrzzl Sep 26, 2024

hwbrzzl Sep 26, 2024

devhaozi left a comment

feat: optimize schedule #657

feat: optimize schedule #657

Conversation

hwbrzzl commented Sep 26, 2024 • edited Loading

📑 Description

✅ Checks

coderabbitai bot commented Sep 26, 2024 • edited Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

github-actions bot left a comment • edited Loading

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

github-actions bot left a comment

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

codecov bot commented Sep 26, 2024 • edited Loading

Codecov Report

hwbrzzl Sep 26, 2024

Choose a reason for hiding this comment

hwbrzzl Sep 26, 2024

Choose a reason for hiding this comment

devhaozi left a comment

Choose a reason for hiding this comment

hwbrzzl commented Sep 26, 2024 •

edited

Loading

coderabbitai bot commented Sep 26, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot left a comment •

edited

Loading

codecov bot commented Sep 26, 2024 •

edited

Loading