Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: isAir and isDirectlyRun in Windows #677

Merged
merged 1 commit into from
Oct 11, 2024
Merged

fix: isAir and isDirectlyRun in Windows #677

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions foundation/path.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
// isAir checks if the application is running using Air.
func isAir() bool {
for _, arg := range os.Args {
if strings.Contains(arg, "/storage/temp") {
if strings.Contains(filepath.ToSlash(arg), "/storage/temp") {

Check warning on line 38 in foundation/path.go

View check run for this annotation

Codecov / codecov/patch

foundation/path.go#L38 

Added line #L38 was not covered by tests
return true
}
}
Expand All @@ -47,5 +47,5 @@
func isDirectlyRun() bool {
executable, _ := os.Executable()
return strings.Contains(filepath.Base(executable), os.TempDir()) ||
(strings.Contains(executable, "/var/folders") && strings.Contains(executable, "/T/go-build")) // macOS
(strings.Contains(filepath.ToSlash(executable), "/var/folders") && strings.Contains(filepath.ToSlash(executable), "/T/go-build")) // macOS

Check warning on line 50 in foundation/path.go

View check run for this annotation

Codecov / codecov/patch

foundation/path.go#L50 

Added line #L50 was not covered by tests
}
devhaozi marked this conversation as resolved.
Show resolved Hide resolved
Loading