Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing key prop #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

reck753
Copy link

@reck753 reck753 commented Aug 22, 2022

Hi @gorhom 👋

I was using portal for quite some time, alongside some of your other packages, and I have to say they are all awesome! Thank you for them!

I had this (below) error for a long time and was just lazy to fix it until now... Please let me know if this is alright.

Warning: Each child in a list should have a unique "key" prop.

Check the render method of `PortalHostComponent`. It was passed a child from MyHostedComponent. See https://reactjs.org/link/warning-keys for more information.
// stack trace...

P.S. Sorry for the tag, I didn't see your status until it was too late. 😓

@reck753
Copy link
Author

reck753 commented Dec 30, 2022

Hi @gorhom 👋

Is there any progress on whether this could be considered?

@pjc0247
Copy link

pjc0247 commented Apr 11, 2023

I think this PR fixes #42

Whelton added a commit to Whelton/react-native-portal that referenced this pull request Jul 11, 2023
If 2 nodes were in the same portal, and one unmounted, the other would be unmounted also in some scenarios. From: gorhom#32
@gorbypark
Copy link

Any chance we can get this merged @gorhom? Simple enough to use patch package to apply this, but it would be nice to have it merged + released.

@pkfms
Copy link

pkfms commented Sep 14, 2024

I just ran into this using portal through Tamagui. As previously mentioned I can use a patch to fix it. Any reason this has not been merged?

@gorhom gorhom self-assigned this Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants