Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get OS and prefill shell with user commands #42

Merged
merged 4 commits into from
Oct 19, 2023
Merged

Conversation

ShishirPatil
Copy link
Member

@ShishirPatil ShishirPatil commented Sep 6, 2023

  • Append command to user bash history and prefill shell. Even though we can append command to bash history, it does not show up in the reverse-i-search without sourcing the shell. This is because the child process cannot modify the environment of the parent caller process stack-overflow reference. So, instead will will pre-fill the shell command with the selected command.
  • Get OS environment
  • Refactor unique ID generation - mostly cosmetic
  • Update server to route LLM based on os environment
  • Test on Ubuntu Linux
  • Test on Darwin (Mac OS)
  • Test on WSL
  • Test on Windows Powershell

Thoughts, suggestions, and reviews welcome!

Relevant to #39 and #12

@Buttars
Copy link

Buttars commented Sep 20, 2023

It would also be nice to be able to edit the command before executing it. Sometimes the LLM gets pretty lose but not perfect and needs some tweaking before being ran. This and the committing to the shell history should likely be behind configuration options. .config/gorilla-cli/config.yml or something similar. Thoughts?

Copy link
Contributor

@royh02 royh02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ShishirPatil ShishirPatil merged commit 386153a into main Oct 19, 2023
@ShishirPatil ShishirPatil deleted the os-history branch October 19, 2023 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants