Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating github actions workflows to test 1.20 and 1.21 #45

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

coreydaley
Copy link
Contributor

@coreydaley coreydaley commented Oct 18, 2023

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Go Version Update
  • Dependency Update

Description

Related Tickets & Documents

  • Related Issue #
  • Closes #

Added/updated tests?

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

Run verifications and test

  • make verify is passing
  • make test is passing

@coreydaley coreydaley enabled auto-merge (squash) October 18, 2023 00:14
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #45 (6b4abc9) into main (a45ea70) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #45   +/-   ##
=======================================
  Coverage   71.25%   71.25%           
=======================================
  Files           1        1           
  Lines          80       80           
=======================================
  Hits           57       57           
  Misses         23       23           

@coreydaley
Copy link
Contributor Author

I think that running the unit tests on linux/windows/mac is a good idea, but we should only need to run the security/linting on linux to reduce resource usage and time to run the tests.

@coreydaley coreydaley merged commit 6a490e2 into main Oct 18, 2023
15 checks passed
@coreydaley coreydaley deleted the coreydaley-patch-4 branch October 18, 2023 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants