PageScroll.js keeps replacing the content of the previous page load #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… test AppModule to not to include prototype.js included and such make the PageScroll component test work
|
I have changed the JAVASCRIPT_INFRASTRUCTURE_PROVIDER to "jquery" in test AppModule, so the tests pass now locally |
|
Hi @got5, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have just added PageScroll component to my Tapestry App.
The first scroll triggered data retrieval works fine and shows the result properly.
However the second scroll data retrieval is broken. It is not appending the returned HTML elements, but replaces first scroll triggered section.
I managed to fix it in my app, by overriding the PageScroll.js as below, however it is not working in PageScrollTest.java due to not finding $ in activeZone.$.clone().
It work in my pure jQuery app, but it seems that this test page is also loading prototype and for some reason not exposing $ via ElementWrapper.
I am not sure how to overcome this challenge. Could you please advise.