Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 2.7 support #243

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adamchainz
Copy link
Contributor

Upstream IPython dropped it in version 6.0.0, in April 2017. I think it's fine to drop it here now.

Would also be good to use this opportunity to mark the release as 1.0.0.

@gotcha
Copy link
Owner

gotcha commented Dec 30, 2021

I would like to keep 2.7 support unless it avoids support for new features...

Upstream IPython dropped it in version 6.0.0, in April 2017. I think it's fine to drop it here now.

Would also be good to use this opportunity to mark the release as 1.0.0.
@adamchainz
Copy link
Contributor Author

Why? It's dead for nearly 2 years now. For those on Python 2, pip will install the old version, thanks to python_requires.

@gotcha
Copy link
Owner

gotcha commented Jan 2, 2022

As said above, if it does not hinder new features, I see no reason to stop support.

Further, I know a lot of people still using Py 2.

@adamchainz
Copy link
Contributor Author

Okay well up to you. You can keep this PR open for when the time comes if you like.

@gotcha
Copy link
Owner

gotcha commented Jan 10, 2022

Good point

@malkstar
Copy link
Contributor

2.7 IPython vulernability fixes won't be installable through pip for #248, as they're installable from source only.

@ssbarnea
Copy link

ssbarnea commented Aug 8, 2022

@gotcha merge it please! Let's avoid disturbing the dead, or better avoid being hunted by zombies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants