Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add download progress bar #1430

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add download progress bar #1430

wants to merge 2 commits into from

Conversation

anhnmt
Copy link

@anhnmt anhnmt commented Sep 4, 2024

I've added a feature that I find necessary, which is the progressbar. I'm having a bit of trouble: https://github.com/gotd/td/pull/1430/files#diff-542426cfaa760b18e8d3570ce615670687cc1937b86140c4af5b67f419088a6cR34-R37

I hope someone will help me optimize this code :)

@anhnmt anhnmt force-pushed the progressbar branch 3 times, most recently from 2c493b5 to 13e2d89 Compare September 8, 2024 04:20
Copy link

codecov bot commented Sep 8, 2024

Codecov Report

Attention: Patch coverage is 2.50000% with 39 lines in your changes missing coverage. Please review.

Project coverage is 70.98%. Comparing base (ac6bc17) to head (13e2d89).
Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
telegram/downloader/parallel.go 4.16% 21 Missing and 2 partials ⚠️
syncio/writer_at.go 0.00% 10 Missing ⚠️
telegram/downloader/downloader.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1430      +/-   ##
==========================================
- Coverage   71.02%   70.98%   -0.04%     
==========================================
  Files         442      442              
  Lines       17744    17783      +39     
==========================================
+ Hits        12602    12624      +22     
- Misses       4209     4220      +11     
- Partials      933      939       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ernado
Copy link
Member

ernado commented Sep 9, 2024

I'm not sure that this should be in main repo, probably https://github.com/gotd/contrib suits better.

Current repo is for generic things.

Also, https://github.com/iyear/tdl managed to implement a progress bar, so it should be possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants