Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip: deprecate skip.If and replace it with assert.SkipIf #232

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dnephin
Copy link
Member

@dnephin dnephin commented Apr 16, 2022

Originally we thought there might be more stuff to include in the skip package. It has been a few years, and we haven't added anything.

This PR deprecates the skip package, and moves the one function to assert.SkipIf. Instead of a very small page it should be fine to move this one exported function to the assert package.

Also improves the godoc a bit, and documents msgAndArgs on assert.Assert as well.

@dnephin dnephin force-pushed the deprecate-skip-pkg branch from 6005812 to bb5ff78 Compare April 16, 2022 21:27
Instead of a very small page it should be fine to move this one exported function to
the assert package.
@dnephin dnephin force-pushed the deprecate-skip-pkg branch from bb5ff78 to d2fbfd7 Compare April 16, 2022 21:29
@dnephin dnephin requested a review from vdemeester April 16, 2022 21:30
@dnephin
Copy link
Member Author

dnephin commented Apr 16, 2022

@vdemeester what do you think? Any concerns with removing the skip package and moving the one function into assert ?

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like reading skip.If (probably better than I would assert.SkipIf) but other than that, no real concern for deprecating skip 🙃 (on super nit is that if a user only used the skip package, now he will have go-cmp as a dependency that he didn't have before.. but it's really a nit)

@dnephin
Copy link
Member Author

dnephin commented Apr 23, 2022

Fair point! My guess is that no one would really use the skip package on its own, because it doesn't do all that much. That's one of my main motivations for moving it into assert. There's no rush to merge this PR. I'll keep it open for a while so we can think about it.

@dnephin dnephin mentioned this pull request Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants