skip: deprecate skip.If and replace it with assert.SkipIf #232
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally we thought there might be more stuff to include in the
skip
package. It has been a few years, and we haven't added anything.This PR deprecates the
skip
package, and moves the one function toassert.SkipIf
. Instead of a very small page it should be fine to move this one exported function to the assert package.Also improves the godoc a bit, and documents
msgAndArgs
onassert.Assert
as well.