Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate_input receives a random seed argument #134

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ngc92
Copy link
Collaborator

@ngc92 ngc92 commented Jan 14, 2025

adds a seed argument to data generation functions.
NOTE This requires an update to existing leaderboard reference files
Here, I've only updated the identity test so far.

@alexzhang13
Copy link
Collaborator

@ngc92 Just one Q about this, in our actual LB evals, how do we enforce a hidden seed that isn't visible to the user?

@alexzhang13
Copy link
Collaborator

alexzhang13 commented Jan 14, 2025

NOTE This requires an update to existing leaderboard reference files

Can we set a default seed on the eval side? Or do you think this is dangerous? Wait nvm lol I see the issue

Copy link
Collaborator

@alexzhang13 alexzhang13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to merge this because the LBs on our server right now aren't really being used. We can just update the example kernels and the reference code once this is merged, just ping me.

@ngc92
Copy link
Collaborator Author

ngc92 commented Jan 14, 2025

I guess the question is whether we should merge this to main, or try to gather more breaking changes and merge them all at once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants