Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reifyTextureViewDescriptor #3969

Merged
merged 5 commits into from
Sep 30, 2024
Merged

Fix reifyTextureViewDescriptor #3969

merged 5 commits into from
Sep 30, 2024

Conversation

kainino0x
Copy link
Collaborator

I updated it incorrectly in the types roll. Not sure why, I just didn't think about it. (Nothing actually triggers this right now because none of the tests are setting usage on the view descriptor, so it doesn't affect any existing tests.)

Issue: #3953


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

I updated it incorrectly in the types roll.
@kainino0x
Copy link
Collaborator Author

@vonture PTAL (no rush)

@vonture
Copy link
Contributor

vonture commented Sep 30, 2024

Thanks Kai!

@kainino0x kainino0x enabled auto-merge (squash) September 30, 2024 21:38
@kainino0x kainino0x merged commit 9d029d3 into gpuweb:main Sep 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants