Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subgroup bitwise tests #3978

Merged
merged 6 commits into from
Oct 18, 2024
Merged

Subgroup bitwise tests #3978

merged 6 commits into from
Oct 18, 2024

Conversation

alan-baker
Copy link
Contributor

  • Tests subgroupAnd, subgroupOr, and subgroupXor
    • data types
    • compute
    • fragment

Passes linux intel, mac AMD and Intel. Most tests pass on Mac M1, but some of the smallest fragment tests (3x3 framebuffer) fail subgroupXor. If I add extra outputs to the test it begins to pass which smells like a driver bug.

Issue: #


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@alan-baker alan-baker requested a review from dneto0 October 3, 2024 15:24
Copy link
Contributor

@dneto0 dneto0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

i looked at kFrameBufferSizes and [3,3] is the smallest case.
LGTM. I guess we'll end up with a failure expectation for apple silicon as a driver bug.

@alan-baker alan-baker enabled auto-merge (squash) October 18, 2024 14:33
@alan-baker alan-baker merged commit 3971de5 into gpuweb:main Oct 18, 2024
1 check passed
@alan-baker alan-baker deleted the subgroup-bitwise branch October 18, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants