-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build both x86_64 and arm64 macOS DMG's #1388
Conversation
@argilo can you please manually rerun the build job on this branch. https://github.com/gqrx-sdr/gqrx/actions/runs/11449528989 it needs to be re-ran by an owner to ensure the secrets for the codesigning make their way into the build artifacts https://stackoverflow.com/questions/73866908/github-actions-main-repository-secret-not-picked-up-from-pull-request-build |
macos_bundle.sh
Outdated
# see https://apple.stackexchange.com/questions/437618/why-is-homebrew-installed-in-opt-homebrew-on-apple-silicon-macs | ||
MACDEPLOYQT6=/usr/local/opt/qt@6/bin/macdeployqt | ||
if [ -f /opt/homebrew/opt/qt@6/bin/macdeployqt ]; then | ||
MACDEPLOYQT6=/opt/homebrew/opt/qt@6/bin/macdeployqt | ||
fi | ||
cp /*/*/lib/SoapySDR/modules*/libPlutoSDRSupport.so Gqrx.app/Contents/soapy-modules | ||
cp /*/*/lib/SoapySDR/modules*/libremoteSupport.so Gqrx.app/Contents/soapy-modules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of these changes, we could probably just replace the start of Homebrew paths with $(brew --prefix)
.
This run will hopefully produce signed binaries: https://github.com/gqrx-sdr/gqrx/actions/runs/11736275097 |
i was able to have my friend @dangoldin load the ARM64 version on his m3 sequoia mac successfully so i'm taking this out of draft. i also updated the the script to use the brew path as you suggested. |
I think I'd rather use the main brew repository. The only reason I didn't is that it didn't have soapyremote at the time.
macdeployqt did not sign these libraries, so I had to do that manually. |
fixes #1104