fix: delete empty settings to correctly use default settings

graasp · Dec 8, 2023 · 0fd4a28 · 0fd4a28
1 parent 399c4fa
commit 0fd4a28
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/src/components/common/settings/SetText.tsx b/src/components/common/settings/SetText.tsx
@@ -24,7 +24,7 @@ const SetText: FC<Prop> = ({
   const [resourceText, setResourceText] = useState(
     DEFAULT_TEXT_RESOURCE_SETTING.text,
   );
-  const { patchAppSetting, postAppSetting, appSettingArray } =
+  const { patchAppSetting, postAppSetting, deleteAppSetting, appSettingArray } =
     useAppSettingContext();
 
   // This state is used to avoid to erase changes if another setting is saved.
@@ -51,10 +51,15 @@ const SetText: FC<Prop> = ({
 
   const handleClickSaveText = (): void => {
     if (textResourceSetting) {
-      patchAppSetting({
+      const payloadAppSetting = {
         data: { text: resourceText },
         id: textResourceSetting.id,
-      });
+      };
+      if (resourceText) {
+        patchAppSetting(payloadAppSetting);
+      } else {
+        deleteAppSetting(payloadAppSetting);
+      }
     } else {
       postAppSetting({ data: { text: resourceText }, name: resourceKey });
     }