-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use prefetch in the home page #699
base: main
Are you sure you want to change the base?
Conversation
- feat(deps): update the QueryClient dev deps to tanstack v5 (was v3)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really great ! Wonderfull work 💪 !
@@ -53,7 +53,6 @@ export default function Providers(props: { children: React.ReactNode }) { | |||
return ( | |||
<QueryClientProvider client={client}> | |||
{children} | |||
{/* <ReactQueryDevtools initialIsOpen={false} /> */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we enable the devtools with ssr ? I think it would be nice :)
@@ -33,7 +33,7 @@ | |||
"@emotion/react": "11.13.0", | |||
"@emotion/server": "11.11.0", | |||
"@emotion/styled": "11.13.0", | |||
"@graasp/query-client": "3.26.0", | |||
"@graasp/query-client": "github:graasp/graasp-query-client#947-prefetch-home-page", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reminder
Quality Gate passedIssues Measures |
For now, the prefetch never refetch the data, except when the
refetchOnMount
is set to true. If the prefetch code is commented, all works correctly (except that's not SSR)...