Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add tag constraints #707

Merged
merged 6 commits into from
Nov 15, 2024
Merged

feat: add tag constraints #707

merged 6 commits into from
Nov 15, 2024

Conversation

pyphilia
Copy link
Contributor

No description provided.

@pyphilia pyphilia self-assigned this Nov 14, 2024
@pyphilia pyphilia requested review from ReidyT and removed request for AmeerAlzerei November 14, 2024 14:01
spaenleh
spaenleh approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just suggest a way to make your test cases more compact with the use of it.each().
For the regex bug I have no idea.

src/tag/constraints.test.ts Outdated Show resolved Hide resolved
@pyphilia pyphilia enabled auto-merge November 15, 2024 09:38
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pyphilia pyphilia added this pull request to the merge queue Nov 15, 2024
Merged via the queue into main with commit e3582c6 Nov 15, 2024
3 checks passed
@graasper graasper mentioned this pull request Nov 15, 2024
Merged
@spaenleh spaenleh deleted the tag-constraints branch November 21, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaenleh spaenleh spaenleh approved these changes

@MatveyK MatveyK Awaiting requested review from MatveyK

@ReidyT ReidyT Awaiting requested review from ReidyT

Assignees

@pyphilia pyphilia

Labels
v5.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pyphilia @spaenleh