Disable header compilation for r-classes #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunkumar9t2
requested review from
minkuan88,
roscrazy and
rifqimfahmi
as code owners
minkuan88
approved these changes
Aug 10, 2022
arunkumar9t2
added a commit
that referenced
this pull request
Aug 12, 2022
This reverts commit eb4b9c3.
akshay-grabtaxi
pushed a commit
that referenced
this pull request
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R.javawith stub values, by defaultjava_librarycompiles it again twice, one in normal and in header mode. Header compilation is wasteful here sincer-classestarget is on the critical path in the databinding module. This change implements idea from Bazel project with Lombok fails to build on Bazel 4.0.0 rc10 bazelbuild/bazel#12837 (comment) which provides a transition to disable headers on a per target basis.- This is needed until Consider generating R class bytecode directly. #35 is implemented.
BuildConfig.ktdirectly instead of generating asrcjarwhich has to be unpacked to compile.