Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split rates and counts for runs #266

Closed
wants to merge 1 commit into from

Conversation

orensbruli
Copy link

No description provided.

@orensbruli orensbruli requested a review from a team as a code owner October 23, 2023 07:23
@orensbruli orensbruli requested review from gabor and zoltanbedi and removed request for a team October 23, 2023 07:23
@CLAassistant
Copy link

CLAassistant commented Oct 23, 2023

CLA assistant check
All committers have signed the CLA.

@zoltanbedi
Copy link
Member

Hey @orensbruli,
Thank you for opening this pr. can you please fix the test?

@b0bcarlson
Copy link

I have some alerting I'd like to do that this would enable. I'd love to fix the test but I don't know Go :(

@ivanahuckova
Copy link
Member

@orensbruli this unfortunately breaks backward compatibility. Could you keep the original fields and add a new ones for rate and count.

Copy link
Member

@ivanahuckova ivanahuckova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks backward compatibility, we should keep the original fields and add a new ones for rate and count.

@ivanahuckova
Copy link
Member

Closing this as there is no activity, but feel free to reopen, if you plan to continue working on this one. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

5 participants