Allow offline providers #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this needs a few tests. It should be easy to write an integration test that checks that the offline commands work without any configured providers and it should prevent regressions (no one caught it in my PR, and no one probably will, without tests, a year from now) |
|
@julienduchesne integration test added! |
julienduchesne
approved these changes
May 9, 2024
cmd/grr/main.go
Outdated
Comment on lines
84
to
88
| providerInitFuncs := []func() grizzly.Provider{ | ||
| func() grizzly.Provider { return grafana.NewProvider(&context.Grafana) }, | ||
| func() grizzly.Provider { return mimir.NewProvider(&context.Mimir) }, | ||
| func() grizzly.Provider { return syntheticmonitoring.NewProvider(&context.SyntheticMonitoring) }, | ||
| } |
There was a problem hiding this comment.
Suggested change
| providerInitFuncs := []func() grizzly.Provider{ | |
| func() grizzly.Provider { return grafana.NewProvider(&context.Grafana) }, | |
| func() grizzly.Provider { return mimir.NewProvider(&context.Mimir) }, | |
| func() grizzly.Provider { return syntheticmonitoring.NewProvider(&context.SyntheticMonitoring) }, | |
| } | |
| providers := []grizzly.Provider{ | |
| grafana.NewProvider(&context.Grafana), | |
| mimir.NewProvider(&context.Mimir), | |
| syntheticmonitoring.NewProvider(&context.SyntheticMonitoring), | |
| } |
Doesn't need to be a func if we're validating in a separate func
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#362 added details of which providers were configured. It also prevented unconfigured
providers from being added to the list of available providers.
This has the unfortunate consequence of preventing "offline" commands from working,
e.g.
grr show,grr listorgrr export.This PR resolves this by still allowing an unconfigured provider to be used for such
situations. Now, an unconfigured provider will just error out when it attempts to
connect to its backend.
Closes #424.