Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tempo-vulture] fix yaml indentation error #3194

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

devoxel
Copy link

@devoxel devoxel commented Jun 27, 2024

Using the following values:

tempoAddress:
  push: "http://p"
  query: "http://q"
annotations:
  foo: bar
  baz: fop

helm template produced yaml that looked like:

  annotations:    baz: fop
    foo: bar

Thye reason was that it was using indent, instead of nindent.

@CLAassistant
Copy link

CLAassistant commented Jun 27, 2024

CLA assistant check
All committers have signed the CLA.

@devoxel
Copy link
Author

devoxel commented Jul 23, 2024

This issue is entirely breaking the use of the annotations param, and fix is simple - anybody free to review?

Using the following values:

	tempoAddress:
	  push: "http://p"
	  query: "http://q"
	annotations:
	  foo: bar
	  baz: fop

helm template produced yaml that looked like:

	  annotations:    baz: fop
	    foo: bar

The reason was that it was using indent, instead of nindent.

Signed-off-by: Aaron Delaney <[email protected]>
@Sheikh-Abubaker Sheikh-Abubaker changed the title tempo-vulture: fix yaml indentation error [tempo-vulture] fix yaml indentation error Jul 30, 2024
Copy link
Collaborator

@Sheikh-Abubaker Sheikh-Abubaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devoxel Could you please fix the CI lint test error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants