[grafana-sampling] upgrade to grafana alloy #3273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlankfo
force-pushed
the
rlankfo/sampling-to-alloy-upgrade
branch
from
5b172cd
to
a7587bb
Compare
Signed-off-by: Robbie Lankford <[email protected]>
rlankfo
force-pushed
the
rlankfo/sampling-to-alloy-upgrade
branch
from
a7587bb
to
2b24f79
Compare
Signed-off-by: Robbie Lankford <[email protected]>
rlankfo
force-pushed
the
rlankfo/sampling-to-alloy-upgrade
branch
from
49c734f
to
299b702
Compare
t00mas
approved these changes
Aug 16, 2024
|
The deployment crashes for me. 
|
|
So It was only happening for a while. I suppose while the statefulset was warming up. |
cedricziel
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the tail sampling helm chart to use Grafana Alloy. This introduces breaking changes. See the README.md file.
In addition, it introduces a
metricsGeneration.legacyconfiguration option set totrueby default. In future releases, this will default tofalse. Using legacy metric names will align the spanmetrics generated by theotelcol.spanmetrics.connectorcomponent to match the metric names generated by the Tempo metrics generator. SettingmetricsGeneration.legacyset tofalsewill use the default metric names. See https://grafana.com/docs/agent/latest/flow/reference/components/otelcol.connector.spanmetrics/#otelcolconnectorspanmetrics for more info.