Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tempo-distributed] add log_discarded_spans config for Tempo distributor to tempo-distrib… #3289

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dastrobu
Copy link

…uted chart.

The new value enabled configuring log_discarded_spans like for log_received_spans as shown below:

distributor:
  config:
    log_discarded_spans:
      enabled: true
    log_received_spans:
      # ...

The feature was introduced in grafana/tempo#3964 and relates to grafana/tempo#3957.

@CLAassistant
Copy link

CLAassistant commented Aug 26, 2024

CLA assistant check
All committers have signed the CLA.

@@ -2,7 +2,7 @@ apiVersion: v2
name: tempo-distributed
description: Grafana Tempo in MicroService mode
type: application
version: 1.17.0
version: 1.18.0
appVersion: 2.5.0
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the app version should be bumped, when it is clear which release log_discarded_spans will be part of. Check the CHANGELOG.md for

[FEATURE] Discarded span logging log_discarded_spans grafana/tempo#3957 (@dastrobu)

@dastrobu dastrobu changed the title add log_discarded_spans config for Tempo distributor to tempo-distrib… [tempo-distributed] add log_discarded_spans config for Tempo distributor to tempo-distrib… Aug 30, 2024
@dastrobu dastrobu force-pushed the tempo-distributed/log_discarded_spans branch 2 times, most recently from a8dfa7b to 05dc6e4 Compare August 30, 2024 09:29
…uted chart.

The new value enabled configuring `log_discarded_spans` like for `log_received_spans` as shown below:

```
distributor:
  config:
    log_discarded_spans:
      enabled: true
    log_received_spans:
      # ...
```

The feature was introduced in [tempo/#3964](grafana/tempo#3964).

Signed-off-by: Daniel Strobusch <[email protected]>
@dastrobu dastrobu force-pushed the tempo-distributed/log_discarded_spans branch from 8ec625d to d490b55 Compare September 11, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants