Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tempo-distributed] templatise services annotations #3303

Merged

Conversation

bodji
Copy link
Contributor

@bodji bodji commented Sep 10, 2024

Allow templating in tempo-distributed chart services annotations

Making possible cool stuff like :

annotations:
  my.domain.tld/param1: {{ .Release.Name }}

@bodji bodji changed the title feat: templatise tempo-distributed chart services annoations [tempo-distributed] templatise services annotations Sep 10, 2024
Copy link
Collaborator

@Sheikh-Abubaker Sheikh-Abubaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bodji could you please resolve the conflicts.

Copy link
Collaborator

@Sheikh-Abubaker Sheikh-Abubaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zanhsieh zanhsieh merged commit 0b93568 into grafana:main Oct 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants