-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tempo-distributed] Add metrics max duration config #3321
[tempo-distributed] Add metrics max duration config #3321
Conversation
Signed-off-by: Brent Villanueva <[email protected]>
Signed-off-by: Brent Villanueva <[email protected]>
When this max_duration config can be merged ? |
Signed-off-by: Brent Villanueva <[email protected]>
Thanks for the ping @abenbachir. The PR was not updated to latest main. Just updated now. We can now able to merge 🙇 |
@Sheikh-Abubaker this PR needs to be reviewed. |
Looks like as a workaround I saw this post in community slack channel: https://grafana.slack.com/archives/C01D981PEE5/p1728294653138369?thread_ts=1728293373.828449&cid=C01D981PEE5
it works on my local too. @abenbachir , looks like we dont need this PR anymore. What do you think? |
yeah i saw that thread as well. |
@bvillanueva-mdsol could you please bump the chart version to 1.19.0 ? Thanks! |
Signed-off-by: Brent Villanueva <[email protected]>
Signed-off-by: Brent Villanueva <[email protected]>
@Sheikh-Abubaker sorry for the late reply. Got it bumped to 1.20.0 on latest updates |
@bvillanueva-mdsol no worries! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@mapno could you please review this. |
Background:
We wanted to expand current metrics generator's config metrics.max_duration from default
3h
to something bigger.Goal:
Allow update on metrics generator's config metrics.max_duration configuration.
Doc: metrics.max_duration is found in this documentation: https://grafana.com/docs/tempo/latest/configuration/#query-frontend