Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed duplication of ${exec.instance.iterationsCompleted} #1547

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

InRiPa
Copy link

@InRiPa InRiPa commented Apr 11, 2024

Hi,

just a small update.
In k6-docs/src/data/markdown/translated-guides/en/02 Using k6/12 Execution context variables.md,
Line 47 and 49 are the same.

@CLAassistant
Copy link

CLAassistant commented Apr 11, 2024

CLA assistant check
All committers have signed the CLA.

@taylorflatt
Copy link
Contributor

@InRiPa - There is a automatic PR template that is super helpful for making sure the changes have been made to the right places and tested.

If you're still interested in making this change, it will need to be updated in the doc/sources directories as well.

@InRiPa InRiPa force-pushed the main branch 3 times, most recently from b7cae3c to f7f6b79 Compare October 31, 2024 10:23
@InRiPa
Copy link
Author

InRiPa commented Oct 31, 2024

What?

just a small update.
In k6-docs/src/data/markdown/translated-guides/en/02 Using k6/12 Execution context variables.md,
Line 47 and 49 are the same.

Additionally, I went through all versions in docs/sources/k6/*. I think, I caught all instances of it.

Branch is rebased to current version.

Checklist

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the npm start command locally and verified that the changes look good.
    • Couldn't get it to work. I used the Docker file to build and run the project
    • I believe, this is not the intended use. E.g. using
        $ podman build -f Dockerfile -t k6-docs .
        $ podman run -it -p 8000:8000 --rm localhost/k6-docs:latest
  • I have made my changes in the docs/sources/k6/next folder of the documentation.
    • see docs/sources/k6/next/using-k6/execution-context-variables.md
  • I have reflected my changes in the docs/sources/v{most_recent_release} folder of the documentation.
    • adjusted same line in v0.47 to v0.54
  • I have reflected my changes in the relevant folders of the two previous k6 versions of the documentation (if still applicable to previous versions).

Related PR(s)/Issue(s)

none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants