-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support proxy CONNECT headers #1147
Conversation
|
Codecov Report
@@ Coverage Diff @@
## master #1147 +/- ##
==========================================
- Coverage 73.61% 73.53% -0.08%
==========================================
Files 144 144
Lines 10527 10534 +7
==========================================
- Hits 7749 7746 -3
- Misses 2321 2328 +7
- Partials 457 460 +3
Continue to review full report at Codecov.
|
Thank you for making this pull request and for advocating for better proxy support! Unfortunately, I'm not sure we would be able to merge the PR right now, or even in the next few months 😞 As I explained in the issue, we currently favor the approach of creating custom transports (#1045 (comment)) for configuring and dealing with HTTP proxies, TLS configurations, HTTP versions and other transport-level details. Adding another global option now, when we know it's very likely going to be deprecated (i.e. moved to a sub-option of something like a new global We still haven't properly evaluated the approach I mentioned above, that's why it doesn't have its own issue and is just described in a comment of an issue about HTTP proxies. However, it seems likely to me that we might choose to do the implementation if 2 stages - first figure out the specifics and fix the global options (i.e. introduce that new |
Codecov Report
@@ Coverage Diff @@
## master #1147 +/- ##
==========================================
- Coverage 73.54% 73.53% -0.02%
==========================================
Files 144 144
Lines 10531 10534 +3
==========================================
+ Hits 7745 7746 +1
- Misses 2327 2328 +1
- Partials 459 460 +1
Continue to review full report at Codecov.
|
I'll close this, since for the reasons I explained in #1147 (comment) and in #1045 (comment) (and other issues as well), we want to support such changes with a new HTTP API properly, instead of tacking them onto the current one, on top of all of its existing issues. #2461 was created to track the first exploratory steps in that direction. |
This PR adds support for custom proxy CONNECT headers. The headers can be added using the
proxyHeaders
option.Example:
Setting proxy headers
Setting proxy
Proxy receives proxy headers