Disable sourcemaps support in babel if input is big #2345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents babel from using up a lot of memory (3.5x as much as before source maps) on really big inputs.
na--
reviewed
Jan 18, 2022
na--
reviewed
Jan 18, 2022
Co-authored-by: na-- <[email protected]>
na--
reviewed
Jan 18, 2022
codebien
requested changes
Jan 18, 2022
js/compiler/compiler.go
Outdated
Comment on lines
151
to
152
| c.logger.Warnf("the source for `%s` needs to go through babel but is over %d bytes. "+ | ||
| "For performance reasons sourcemaps support will be disabled for this particular file.", |
There was a problem hiding this comment.
Should we mention K6_DEBUG_SOURCEMAP_FILESIZE_LIMIT?
There was a problem hiding this comment.
I think we shouldn't mention this, for a couple of reasons:
K6_DEBUG_SOURCEMAP_FILESIZE_LIMIT=whatever k6 cloudwon't work- we intend to get rid of this option eventually
So we shouldn't really document this. It's a temporary option until we get rid of Babel. We can always mention it and the caveats if someone asks in the forum.
| code, srcMap, err = c.babel.transformImpl(c.logger, src, filename, c.Options.SourceMapLoader != nil, inputSrcMap) | ||
| sourceMapEnabled := c.Options.SourceMapLoader != nil | ||
| maxSrcLenForBabelSourceMapOnce.Do(func() { | ||
| // TODO: drop this code and everything it's connected to when babel is dropped |
There was a problem hiding this comment.
Do we have an issue to link?
There was a problem hiding this comment.
mmm...if we don't have one yet, I'm for creating one dedicated with the steps we plan for dropping babel. For example, it would be useful to have somewhere a link to dop251/goja#348 and this potential new issue could be a good candidate, IMHO.
It's mentioned in your comment, sorry, my fault.
Co-authored-by: Ivan <[email protected]>
Co-authored-by: Ivan <[email protected]>
Merged
oleiade
pushed a commit
that referenced
this pull request
Jan 26, 2022
This prevents babel from using up a lot of memory (3.5x as much as before source maps) on really big inputs. Co-authored-by: na-- <[email protected]> Co-authored-by: Ivan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents babel from using up a lot of memory (3.5x as much as
before source maps) on really big inputs.