Increase and improve integration tests #2795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cleanup function would have never been called, since expectedExitCode was always 0 in the constructor.
…rted This is a simplified and better alternative to the existing TestEngineRunsTeardownEvenAfterTestRunIsAborted test for the Engine.
na--
force-pushed
the
yet-more-integration-tests
branch
2 times, most recently
from
3f62847
to
9740799
Compare
na--
force-pushed
the
yet-more-integration-tests
branch
from
9740799
to
adff941
Compare
olegbespalov
reviewed
Dec 5, 2022
olegbespalov
reviewed
Dec 5, 2022
na--
force-pushed
the
yet-more-integration-tests
branch
from
adff941
to
f18a3be
Compare
olegbespalov
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried to make the commits in this PR very self-contained, so it might be easier to review them one by one. However, given that the only changes are in tests, it shouldn't matter too much either way.
The PR copies (with improvements) some of the more useful
core.Enginetests, in preparation for #1889. It also makes some minor fixes and improvements to the integration test framework and adds rudimentary support (and a few tests that) for verifying metrics sent to the JSON output, for extra assurance. It doesn't have any functional changes, so it should be safe to merge as soon as it's reviewed.