Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics engine tests #2878

Merged
merged 2 commits into from
Feb 2, 2023
Merged

Conversation

codebien
Copy link
Contributor

@codebien codebien commented Jan 26, 2023

#2815 (comment)

// TODO: refactor and move the tests that still make sense in other packages

It resolves the unit tests parts

@codebien codebien self-assigned this Jan 26, 2023
@codebien codebien force-pushed the refactor/metrics-engine-tests branch 2 times, most recently from 8633b9f to 3bbd9f9 Compare January 27, 2023 10:37
@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2023

Codecov Report

Merging #2878 (9df40a0) into remove-the-engine (27b1a4d) will decrease coverage by 0.19%.
The diff coverage is 80.39%.

❗ Current head 9df40a0 differs from pull request most recent head 5847bdc. Consider uploading reports for the commit 5847bdc to get more accurate results

@@                  Coverage Diff                  @@
##           remove-the-engine    #2878      +/-   ##
=====================================================
- Coverage              76.75%   76.56%   -0.19%     
=====================================================
  Files                    224      222       -2     
  Lines                  16835    16765      -70     
=====================================================
- Hits                   12921    12836      -85     
- Misses                  3080     3094      +14     
- Partials                 834      835       +1     
Flag Coverage Δ
ubuntu 76.56% <80.39%> (-0.05%) ⬇️
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/ui.go 68.87% <ø> (ø)
cmd/run.go 70.61% <75.43%> (ø)
output/manager.go 84.09% <91.66%> (ø)
metrics/engine/engine.go 88.88% <100.00%> (+3.54%) ⬆️
loader/filesystems.go 60.00% <0.00%> (-40.00%) ⬇️
js/common/initenv.go 66.66% <0.00%> (-33.34%) ⬇️
api/v1/metric.go 54.54% <0.00%> (-13.64%) ⬇️
js/modulestest/modulestest.go 66.66% <0.00%> (-11.12%) ⬇️
js/modules/k6/experimental/tracing/client.go 61.11% <0.00%> (-7.76%) ⬇️
api/v1/status_routes.go 53.06% <0.00%> (-6.13%) ⬇️
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@codebien codebien marked this pull request as ready for review January 27, 2023 10:51
@codebien codebien requested a review from na-- January 27, 2023 10:51
@na-- na-- force-pushed the remove-the-engine branch 3 times, most recently from ee62441 to 943b1e7 Compare January 30, 2023 18:04
@codebien codebien force-pushed the refactor/metrics-engine-tests branch from 3bbd9f9 to 48c7319 Compare January 31, 2023 13:34
metrics/engine/engine.go Outdated Show resolved Hide resolved
@codebien codebien force-pushed the refactor/metrics-engine-tests branch 2 times, most recently from d16a4f8 to 108b509 Compare February 1, 2023 08:55
@codebien codebien requested a review from na-- February 1, 2023 09:26
@codebien codebien force-pushed the refactor/metrics-engine-tests branch from be4ac3a to d707688 Compare February 1, 2023 16:39
@codebien codebien force-pushed the refactor/metrics-engine-tests branch from d707688 to 985c770 Compare February 1, 2023 21:50
@codebien codebien force-pushed the refactor/metrics-engine-tests branch from 985c770 to 5847bdc Compare February 1, 2023 21:53
Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codebien codebien merged commit b12a4ae into remove-the-engine Feb 2, 2023
@codebien codebien deleted the refactor/metrics-engine-tests branch February 2, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants