Split Scheduler.Run() into Init() and Run() again
#2893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts a big part of #2885 because with all of the logic in Run(), k6 didn't know if it needed to wait when --linger was specified. In general, if a script error or test.abort() occurs during init, --linger should not apply and k6 should exit immediately. But if test.abort() is called during the test run itself, or the test was stopped in some other way besides Ctrl+C, --linger means that k6 should not exit immediately after stopping the test.
Codecov Report
@@ Coverage Diff @@
## remove-the-engine #2893 +/- ##
=====================================================
- Coverage 76.75% 76.67% -0.08%
=====================================================
Files 224 222 -2
Lines 16835 16847 +12
=====================================================
- Hits 12921 12917 -4
- Misses 3080 3090 +10
- Partials 834 840 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
codebien
approved these changes
Feb 2, 2023
mstoykov
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts a big part of #2885 because, with all of the logic in
Run(), k6 didn't know if it needed to wait when--lingerwas specified.In general, if a script error or
test.abort()occurs during init,--lingershould not apply and k6 should exit immediately. But iftest.abort()is called during the test run itself, or the test was stopped in some other way besidesCtrl+C(e.g. REST API, thresholds withabortOnFail),--lingermeans that k6 should not exit immediately after stopping the test.This PR is on top of #2815, which we should later merge in
master. #2804 is a somewhat related issue, where I'll also document this somewhat hidden and implicit requirements.