Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Notes for v0.54.0 #3949

Open
wants to merge 32 commits into
base: master
Choose a base branch
from
Open

Release Notes for v0.54.0 #3949

wants to merge 32 commits into from

Conversation

olegbespalov
Copy link
Contributor

@olegbespalov olegbespalov commented Sep 12, 2024

What?

A release notes.

Why?

It's part of the release

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@olegbespalov olegbespalov changed the title Release v0.54.0 Release Notes for v0.54.0 Sep 12, 2024
@olegbespalov olegbespalov self-assigned this Sep 12, 2024
@olegbespalov olegbespalov added this to the v0.54.0 milestone Sep 12, 2024
@olegbespalov olegbespalov marked this pull request as ready for review September 13, 2024 13:08
release notes/v0.54.0.md Outdated Show resolved Hide resolved
release notes/v0.54.0.md Outdated Show resolved Hide resolved
release notes/v0.54.0.md Outdated Show resolved Hide resolved
release notes/v0.54.0.md Outdated Show resolved Hide resolved
Copy link
Contributor

@heitortsergent heitortsergent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a lot of comments but they're mostly small edits. 🙇

release notes/v0.54.0.md Outdated Show resolved Hide resolved
release notes/v0.54.0.md Outdated Show resolved Hide resolved
release notes/v0.54.0.md Outdated Show resolved Hide resolved
- [#3913](https://github.com/grafana/k6/pull/3913) changes mapping of the Golang's `math/big.Int` type to `bigint` type in k6.
- [#3922](https://github.com/grafana/k6/pull/3922) removes `lib.Min` and `lib.Max` from k6's Go API, which could affect custom extensions that rely on these functions.
- [#3838](https://github.com/grafana/k6/pull/3838) remove `k6/experimental/timers` - they are now available globally and no import is needed.
- [#3944](https://github.com/grafana/k6/pull/3844) updates to `k6/experimental/websockets` made the default to binaryType to be `"blob"` as per the specification. Previously it was not set by default and required to be set and before that it was `"arraybuffer"`. With this change `k6/experimental/websockets` is now compliant with the specification.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [#3944](https://github.com/grafana/k6/pull/3844) updates to `k6/experimental/websockets` made the default to binaryType to be `"blob"` as per the specification. Previously it was not set by default and required to be set and before that it was `"arraybuffer"`. With this change `k6/experimental/websockets` is now compliant with the specification.
- [#3944](https://github.com/grafana/k6/pull/3844) updates to `k6/experimental/websockets` made the `binaryType` default value equal to `"blob"`, as per the specification. In previous versions, the default value was not set, or it was equal to `"arraybuffer"`. With this change, `k6/experimental/websockets` is now compliant with the specification.

I reworded it a bit to make it easier to read, but I'm wondering if we could make it more concise and just say:

"- #3944 updates to k6/experimental/websockets made the binaryType default value equal to "blob". With this change, k6/experimental/websockets is now compliant with the specification."

What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm not mistaken previously it was always arraybuffer, I mean we had no case where default hasn't been set. But probably @mstoykov is the best person to chime in

Comment on lines +20 to +22
As part of Grafana Labs, k6 got renamed to Grafana k6, instead of k6.io. We also had a purple icon making a bit jarring next to all the other orange-y ones.

As such in this release we also got a new logo and the terminal banner has been redesigned to more closely match the current branding.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
As part of Grafana Labs, k6 got renamed to Grafana k6, instead of k6.io. We also had a purple icon making a bit jarring next to all the other orange-y ones.
As such in this release we also got a new logo and the terminal banner has been redesigned to more closely match the current branding.
As part of joining Grafana Labs in 2021, k6 was renamed to Grafana k6. The original k6 logo and branding was purple, which didn't fit very well next to the Grafana Labs orange logo and all its other products.
In this release, we have a new logo in a new color, and the terminal banner has been redesigned to match the current branding more closely.

release notes/v0.54.0.md Outdated Show resolved Hide resolved
release notes/v0.54.0.md Outdated Show resolved Hide resolved
release notes/v0.54.0.md Outdated Show resolved Hide resolved
release notes/v0.54.0.md Outdated Show resolved Hide resolved
release notes/v0.54.0.md Outdated Show resolved Hide resolved
Comment on lines 9 to 10
- [#3913](https://github.com/grafana/k6/pull/3913) changes mapping of the Golang's `math/big.Int` type to `bigint` type in k6.
- [#3922](https://github.com/grafana/k6/pull/3922) removes `lib.Min` and `lib.Max` from k6's Go API, which could affect custom extensions that rely on these functions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these two items require any docs updates? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These luckily no since they are part of the k6's Golang's API (https://pkg.go.dev/go.k6.io/[email protected]/lib#Max)


</details>

### New `k6 cloud upload` command for uploading test files to the cloud [`#3906`](https://github.com/grafana/k6/pull/3906)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still need a docs PR for this update.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joanlopez is away, I'll take care of it as soon as possible 👍🏻

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've opened grafana/k6-docs#1734 accordingly 🙇🏻


Thank you, @lzakharov!

#### New argument `meta` for gRPC's stream callbacks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might need a docs update as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember that @joanlopez wants to do a PR for that, but probably (I can't see branch neither PR) was busy before PTO so I'll take care of it

Co-authored-by: Heitor Tashiro Sergent <[email protected]>
inancgumus
inancgumus previously approved these changes Sep 20, 2024
Co-authored-by: Heitor Tashiro Sergent <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants