Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "fix(deps): update module github.com/shirou/gopsutil/v4 to v4.24.9 (#14357)" #14437

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

trevorwhitney
Copy link
Collaborator

@trevorwhitney trevorwhitney commented Oct 9, 2024

What this PR does / why we need it:

This commit broke my ability to use delve from the command line on MacOS 15.0.1

This reverts commit c8e6a9d, and instead upgrades to 4.24.8 which was before their cgo -> purego change shirou/gopsutil#1702

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@trevorwhitney trevorwhitney requested a review from a team as a code owner October 9, 2024 15:12
@trevorwhitney trevorwhitney changed the title Revert "fix(deps): update module github.com/shirou/gopsutil/v4 to v4.24.9 (#14357)" fix: Revert "fix(deps): update module github.com/shirou/gopsutil/v4 to v4.24.9 (#14357)" Oct 9, 2024
@trevorwhitney
Copy link
Collaborator Author

Issue filed shirou/gopsutil#1734

I'm guessing this is related to shirou/gopsutil#1702 which switched from cgo to purego and was included in 4.24.9

@trevorwhitney trevorwhitney merged commit d53955b into main Oct 9, 2024
60 checks passed
@trevorwhitney trevorwhitney deleted the revert-c8e6a9d3 branch October 9, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants