-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Tanka in the mimir-build-image #8030
Conversation
Signed-off-by: Marco Pracucci <[email protected]>
Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we update mixtool
as well? latest version supports new histogram functions when validating rule/alert queries. 🙏
Latest commit is currently this one: monitoring-mixins/mixtool@779c8b3 Commit that updated Prometheus was: monitoring-mixins/mixtool@26d9c7a |
Will do in a separate PR. I need to unblock #8028 asap. |
ok, no worries. It was on my todo list for a while, your PR reminded me of it :) |
Signed-off-by: Marco Pracucci <[email protected]>
Not building new version of mimir-build-image. This PR modifies |
What this PR does
We're running jsonnet tests in CI with a very old version of Tanka. The old version of Tanka gets shipped with an old version of jsonnet, which doesn't support new jsonnet functions. In this PR I'm upgrading Tanka to unblock #8028 (requires
std.parseYaml
).Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.