Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tanka in the mimir-build-image #8030

Merged
merged 3 commits into from
May 2, 2024
Merged

Conversation

pracucci
Copy link
Collaborator

@pracucci pracucci commented May 2, 2024

What this PR does

We're running jsonnet tests in CI with a very old version of Tanka. The old version of Tanka gets shipped with an old version of jsonnet, which doesn't support new jsonnet functions. In this PR I'm upgrading Tanka to unblock #8028 (requires std.parseYaml).

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

Copy link
Contributor

github-actions bot commented May 2, 2024

Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version grafana/mimir-build-image:pr8030-cf783bf13c. This can take up to 1 hour.

Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we update mixtool as well? latest version supports new histogram functions when validating rule/alert queries. 🙏

@pstibrany
Copy link
Member

could we update mixtool as well? latest version supports new histogram functions when validating rule/alert queries. 🙏

Latest commit is currently this one: monitoring-mixins/mixtool@779c8b3

Commit that updated Prometheus was: monitoring-mixins/mixtool@26d9c7a

@pracucci
Copy link
Collaborator Author

pracucci commented May 2, 2024

could we update mixtool as well? latest version supports new histogram functions when validating rule/alert queries. 🙏

Will do in a separate PR. I need to unblock #8028 asap.

@pstibrany
Copy link
Member

Will do in a separate PR. I need to unblock #8028 asap.

ok, no worries. It was on my todo list for a while, your PR reminded me of it :)

Signed-off-by: Marco Pracucci <[email protected]>
Copy link
Contributor

github-actions bot commented May 2, 2024

Not building new version of mimir-build-image. This PR modifies mimir-build-image/Dockerfile, but the image grafana/mimir-build-image:pr8030-cf783bf13c already exists.

@pracucci pracucci marked this pull request as ready for review May 2, 2024 16:18
@pracucci pracucci requested review from wilfriedroset, vaxvms, bubu11e and a team as code owners May 2, 2024 16:18
@pracucci pracucci merged commit 8d5fd6e into main May 2, 2024
30 checks passed
@pracucci pracucci deleted the upgrade-tanka-in-build-image branch May 2, 2024 16:18
@pracucci pracucci mentioned this pull request May 2, 2024
4 tasks
@pracucci
Copy link
Collaborator Author

pracucci commented May 2, 2024

could we update mixtool as well? latest version supports new histogram functions when validating rule/alert queries. 🙏

Will do in a separate PR. I need to unblock #8028 asap.

See: #8032

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants