Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query-tee: add equivalent errors for string expression for range queries #9366

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

charleskorn
Copy link
Contributor

@charleskorn charleskorn commented Sep 23, 2024

What this PR does

This PR builds on #9143 to add another class of equivalent errors.

Which issue(s) this PR fixes or relates to

#9143

Checklist

  • [n/a] Tests updated.
  • [n/a] Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • [n/a] about-versioning.md updated with experimental features.

@charleskorn charleskorn marked this pull request as ready for review September 23, 2024 03:20
@charleskorn charleskorn requested a review from a team as a code owner September 23, 2024 03:20
Copy link
Contributor

@jhesketh jhesketh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also get this added to the list of tests?

@charleskorn
Copy link
Contributor Author

Could we also get this added to the list of tests?

My intention is that we'll add more and more of these equivalence classes over time, most of which will be simple patterns like these. I don't think it's worth adding more test cases for these, provided the general functionality of error equivalence is tested, but open to other opinions.

Copy link
Contributor

@jhesketh jhesketh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I'm not blocking on it, but maybe it's worth having a more generic test that loads each errorEquivalenceClasses pair, extracts the matching string and checks if it outputs the correct result (if that makes sense)

@charleskorn charleskorn merged commit 47aae6a into main Sep 23, 2024
29 checks passed
@charleskorn charleskorn deleted the charleskorn/query-tee-error-equivalence branch September 23, 2024 04:19
@charleskorn
Copy link
Contributor Author

Okay, I'm not blocking on it, but maybe it's worth having a more generic test that loads each errorEquivalenceClasses pair, extracts the matching string and checks if it outputs the correct result (if that makes sense)

This would be difficult to do as each pattern is a regex, not a string (although some of the patterns are just simple matches).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants