Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Querier tests: compare floats with epsilon #9854

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Querier tests: compare floats with epsilon #9854

merged 1 commit into from
Nov 8, 2024

Conversation

bboreham
Copy link
Contributor

@bboreham bboreham commented Nov 8, 2024

What this PR does

In querier tests, compare floats with epsilon instead of exact equality.

Checklist

  • Tests updated.
  • NA Documentation added.
  • NA CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].

@bboreham bboreham requested a review from a team as a code owner November 8, 2024 11:46
@bboreham bboreham mentioned this pull request Nov 8, 2024
Draft
4 tasks
aknuds1
aknuds1 approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aknuds1 aknuds1 merged commit a10e092 into main Nov 8, 2024
29 checks passed
@aknuds1 aknuds1 deleted the querier-epsilon branch November 8, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknuds1 aknuds1 aknuds1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bboreham @aknuds1