-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compactor: concurrently get deletion marks for blocks #9881
compactor: concurrently get deletion marks for blocks #9881
Conversation
With a lot of blocks churn (for example a lot of OOO blocks) getting the deletion marks for newly discovered blocks can take a long time (13 minutes). This PR introduces changes the bucket index updater to request 16 deletions marks concurrently (same as the number of block deleted in parallel). Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-9881-to-r314 origin/r314
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 94255ac58ccfb68a82963d45ba912e17f3c784d0
# Push it to GitHub
git push --set-upstream origin backport-9881-to-r314
git switch main
# Remove the local backport branch
git branch -D backport-9881-to-r314 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-9881-to-r314 origin/r314
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 94255ac58ccfb68a82963d45ba912e17f3c784d0
# Push it to GitHub
git push --set-upstream origin backport-9881-to-r314
git switch main
# Remove the local backport branch
git branch -D backport-9881-to-r314 Then, create a pull request where the |
* compactor: concurrently get deletion marks for blocks With a lot of blocks churn (for example a lot of OOO blocks) getting the deletion marks for newly discovered blocks can take a long time (13 minutes). This PR introduces changes the bucket index updater to request 16 deletions marks concurrently (same as the number of block deleted in parallel). Signed-off-by: Dimitar Dimitrov <[email protected]> * Add CHANGELOG.md entry Signed-off-by: Dimitar Dimitrov <[email protected]> * Restore error handling Signed-off-by: Dimitar Dimitrov <[email protected]> --------- Signed-off-by: Dimitar Dimitrov <[email protected]> Co-authored-by: Ganesh Vernekar <[email protected]> (cherry picked from commit 94255ac)
What this PR does
With a lot of blocks churn (for example a lot of OOO blocks) getting the deletion marks for newly discovered blocks can take a long time (13 minutes).
This PR introduces changes the bucket index updater to request 16 deletions marks concurrently (same as the number of block deleted in parallel).
This is one example of a cleanup taking 20 minutes. 13 of those were in getting the deletion marks
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.