Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update goja #45

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Update goja #45

merged 2 commits into from
Aug 29, 2024

Conversation

joanlopez
Copy link
Contributor

  • Added support for separators in numeric literals.

  • Improved support for Unicode code point escapes (\u{...}) in regexes.

  • Improved number parsing compatibility.


* Added support for separators in numeric literals.

* Improved support for Unicode code point escapes (\u{...}) in regexes.

* Improved number parsing compatibility.

---------

Co-authored-by: Joan López de la Franca Beltran <[email protected]>
@joanlopez joanlopez requested a review from mstoykov August 29, 2024 07:30
@joanlopez joanlopez self-assigned this Aug 29, 2024
@joanlopez joanlopez requested a review from a team as a code owner August 29, 2024 07:30
@joanlopez joanlopez requested a review from olegbespalov August 29, 2024 07:30
Copy link
Contributor

@olegbespalov olegbespalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mstoykov
Copy link
Collaborator

I prefer that you do a merge commit here directly with the master branch from goja.

In this way the next time this code gets changed you don't need to cherry-pick and merge conflict fix changes.

Given how common it is for fixes or even feature additions to touch across multiple places, making it easy to not have merge conflicts seems like a must if we want to do this more.

@joanlopez
Copy link
Contributor Author

I prefer that you do a merge commit here directly with the master branch from goja.

In this way the next time this code gets changed you don't need to cherry-pick and merge conflict fix changes.

Given how common it is for fixes or even feature additions to touch across multiple places, making it easy to not have merge conflicts seems like a must if we want to do this more.

Sure, of course! Like now? 🤔

@mstoykov
Copy link
Collaborator

Yeah and also the "merge pull request" so again .. git can figure out the merge conflict resolution later

@joanlopez joanlopez merged commit 447e8c6 into main Aug 29, 2024
8 checks passed
@joanlopez joanlopez deleted the update-goja branch August 29, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants