Skip to content

Commit

Permalink
Remove requiring github token for vendor-check (#4082)
Browse files Browse the repository at this point in the history
* do we need the token?

* will this fix drone
  • Loading branch information
ie-pham authored Sep 13, 2024
1 parent 85950ca commit 9f173f2
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 12 deletions.
26 changes: 24 additions & 2 deletions .drone/drone.yml
Original file line number Diff line number Diff line change
Expand Up @@ -358,8 +358,12 @@ steps:
}
]
}
github_token:
from_secret: gh_token
github_app_id:
rom_secret: tempo-app-id
github_app_installation_id:
from_secret: tempo-app-installation-id
github_app_private_key:
from_secret: tempo-app-private-key
trigger:
ref:
- refs/heads/main
Expand Down Expand Up @@ -564,6 +568,24 @@ get:
kind: secret
name: gpg_passphrase
---
get:
name: tempo-app-id
path: ci/data/repo/grafana/tempo/github-app
kind: secret
name: app-id
---
get:
name: tempo-app-installation-id
path: ci/data/repo/grafana/tempo/github-app
kind: secret
name: app-installation-id
---
get:
name: tempo-app-private-key
path: ci/data/repo/grafana/tempo/github-app
kind: secret
name: app-private-key
---
kind: signature
hmac: bee5601dffa0f46559f5d8734ebda1261ec9171a3dca7add1a23188f6f162945

Expand Down
10 changes: 0 additions & 10 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -129,14 +129,6 @@ jobs:
name: Vendor check
runs-on: ubuntu-latest
steps:
- name: Get app token
uses: actions/create-github-app-token@v1
id: get-github-app-token
with:
app-id: ${{secrets.APP_ID}}
private-key: ${{secrets.APP_PRIVATE_KEY}}
owner: ${{github.repository_owner}}

- name: Check out code
uses: actions/checkout@v4

Expand All @@ -147,8 +139,6 @@ jobs:

- name: Install Protoc
uses: arduino/setup-protoc@v3
with:
repo-token: ${{ steps.get-github-app-token.outputs.token }}

- name: Check vendor
run: make vendor-check
Expand Down

0 comments on commit 9f173f2

Please sign in to comment.