-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-v2.1] [DOC] Update metrics generator doc and add best practices #2569
[release-v2.1] [DOC] Update metrics generator doc and add best practices #2569
Conversation
* Update metrics generator doc * Updates from doc validator * Fix typos and links * Fix typo in admonition * Fix validator issues, part 2 * Apply suggestions from code review Co-authored-by: Heds Simons <[email protected]> * Move content and fix admonitions * Added best practices * Update docs/sources/tempo/metrics-generator/span_metrics.md * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Eve Meelan <[email protected]> * Fix links, admonitions --------- Co-authored-by: Heds Simons <[email protected]> Co-authored-by: Eve Meelan <[email protected]> (cherry picked from commit 9499cb9) # Conflicts: # docs/sources/tempo/configuration/grafana-agent/service-graphs.md # docs/sources/tempo/metrics-generator/_index.md # docs/sources/tempo/metrics-generator/service_graphs.md # docs/sources/tempo/metrics-generator/span_metrics.md # docs/sources/tempo/operations/_index.md # docs/sources/tempo/traceql/_index.md
Can we add information about MetricsIngestionSlack (in cloud we are defaulting this to 30s) so all spans sent to the metrics-generator with an end time more than 30s in the past would get discarded/rejected. This metrics is exposed in |
@joe-elliott Would you re-review? |
@ie-pham That looks like is was added in PR#2424, which isn't released yet. I can add the information to PR#2580, where I'm adding the changes from this 2.1 backport PR to the files in main. |
The metrics from spans discussion in particular is very well done. It really illuminates where the cardinality comes from. |
Thank you! As always, this is a team effort for content. @hedss had some excellent content already written that was the basis for the cardinality and active series pages. There were also other pages written by Mario, Koenraad, you, and others that informed the content too. |
Backport 9499cb9 from #2563
Backport content from metrics-generator and best practices doc update. This PR should not have any content that is unreleased.