Make metrics-generator ingestion slack per tenant #2589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ie-pham
changed the title
ie-pham
requested review from
knylander-grafana,
joe-elliott,
annanay25,
mdisibio,
mapno,
kvrhdn,
zalegrala,
electron0zero and
stoewer
as code owners
joe-elliott
reviewed
Jun 23, 2023
zalegrala
reviewed
Jun 23, 2023
joe-elliott
reviewed
Jun 28, 2023
joe-elliott
reviewed
Aug 18, 2023
joe-elliott
reviewed
Aug 22, 2023
joe-elliott
reviewed
Aug 22, 2023
kvrhdn
approved these changes
Aug 24, 2023
| overrides metricsGeneratorOverrides | ||
| instanceID string | ||
| overrides metricsGeneratorOverrides | ||
| ingestionSlackOverride atomic.Int64 |
There was a problem hiding this comment.
Nitpick: I like keeping the time unit in variable names so it's always obvious.
Suggested change
| ingestionSlackOverride atomic.Int64 | |
| ingestionSlackDurationNanos atomic.Int64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: Make metrics-generator ingestion slack a per tenant config for when a tenant requires a much higher slack than the default '30s'
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]