Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a generator troubleshooting page #2772

Merged
merged 16 commits into from
Aug 10, 2023
Merged

Add a generator troubleshooting page #2772

merged 16 commits into from
Aug 10, 2023

Conversation

joe-elliott
Copy link
Member

Adds a trouble shooting page for metrics generator. There have been a lot of questions like

#2771

and I feel like this is a gap in the docs.

knylander-grafana
knylander-grafana approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@knylander-grafana knylander-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this. It's definitely been something we've needed.

zalegrala
zalegrala approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@zalegrala zalegrala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a great start to point folks at.

knylander-grafana
knylander-grafana approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@knylander-grafana knylander-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent updates. I've added a few minor suggestions, mostly missing commas and suggested word changes to clarify. Also, we use "metrics-generator" in the docs, so I've updated the text to reflect the hyphen.

joe-elliott and others added 10 commits August 9, 2023 14:26
@joe-elliott @knylander-grafana
Update docs/sources/tempo/operations/troubleshooting/metrics-generato…
e7125d2 
…r.md

Co-authored-by: Kim Nylander <[email protected]>
@joe-elliott @knylander-grafana
Update docs/sources/tempo/operations/troubleshooting/metrics-generato…
89f6783 
…r.md

Co-authored-by: Kim Nylander <[email protected]>
@joe-elliott @knylander-grafana
Update docs/sources/tempo/operations/troubleshooting/metrics-generato…
b10d5fd 
…r.md

Co-authored-by: Kim Nylander <[email protected]>
@joe-elliott @knylander-grafana
Update docs/sources/tempo/operations/troubleshooting/metrics-generato…
f44bd01 
…r.md

Co-authored-by: Kim Nylander <[email protected]>
@joe-elliott @knylander-grafana
Update docs/sources/tempo/operations/troubleshooting/metrics-generato…
18ebafd 
…r.md

Co-authored-by: Kim Nylander <[email protected]>
@joe-elliott @knylander-grafana
Update docs/sources/tempo/operations/troubleshooting/metrics-generato…
d1d0a60 
…r.md

Co-authored-by: Kim Nylander <[email protected]>
@joe-elliott @knylander-grafana
Update docs/sources/tempo/operations/troubleshooting/metrics-generato…
e6c01cf 
…r.md

Co-authored-by: Kim Nylander <[email protected]>
@joe-elliott @knylander-grafana
Update docs/sources/tempo/operations/troubleshooting/metrics-generato…
f0c8acc 
…r.md

Co-authored-by: Kim Nylander <[email protected]>
@joe-elliott @knylander-grafana
Update docs/sources/tempo/operations/troubleshooting/metrics-generato…
b6a2e22 
…r.md

Co-authored-by: Kim Nylander <[email protected]>
@joe-elliott @knylander-grafana
Update docs/sources/tempo/operations/troubleshooting/metrics-generato…
7703392 
…r.md

Co-authored-by: Kim Nylander <[email protected]>
yvrhdn
yvrhdn approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@yvrhdn yvrhdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I think this page will be very valuable. It's very extensive and covers every area that could cause trouble as far as I'm aware.

docs/sources/tempo/operations/troubleshooting/metrics-generator.md Show resolved Hide resolved
docs/sources/tempo/operations/troubleshooting/metrics-generator.md Show resolved Hide resolved
docs/sources/tempo/operations/troubleshooting/metrics-generator.md Outdated Show resolved Hide resolved
@joe-elliott
review notes
7c019d0 
Signed-off-by: Joe Elliott <[email protected]>
@joe-elliott joe-elliott merged commit 5e51eb7 into grafana:main Aug 10, 2023
13 of 14 checks passed
@knylander-grafana knylander-grafana added type/docs Improvements or additions to documentation backport release-v2.2 labels Aug 29, 2023
@github-actions github-actions bot mentioned this pull request Aug 29, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Aug 29, 2023
@joe-elliott @grafana-delivery-bot
Add a generator troubleshooting page (#2772)
9020e3e 
* Add a generator troubleshooting page

Signed-off-by: Joe Elliott <[email protected]>

* Update docs/sources/tempo/operations/troubleshooting/metrics-generator.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/troubleshooting/metrics-generator.md

Co-authored-by: Kim Nylander <[email protected]>

* added more details

Signed-off-by: Joe Elliott <[email protected]>

* Update docs/sources/tempo/operations/troubleshooting/metrics-generator.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/troubleshooting/metrics-generator.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/troubleshooting/metrics-generator.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/troubleshooting/metrics-generator.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/troubleshooting/metrics-generator.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/troubleshooting/metrics-generator.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/troubleshooting/metrics-generator.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/troubleshooting/metrics-generator.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/troubleshooting/metrics-generator.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/troubleshooting/metrics-generator.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/troubleshooting/metrics-generator.md

Co-authored-by: Kim Nylander <[email protected]>

* review notes

Signed-off-by: Joe Elliott <[email protected]>

---------

Signed-off-by: Joe Elliott <[email protected]>
Co-authored-by: Kim Nylander <[email protected]>
(cherry picked from commit 5e51eb7)
knylander-grafana pushed a commit that referenced this pull request Aug 29, 2023
@github-actions @joe-elliott
Add a generator troubleshooting page (#2772) (#2862)
547df02 
* Add a generator troubleshooting page

Signed-off-by: Joe Elliott <[email protected]>

* Update docs/sources/tempo/operations/troubleshooting/metrics-generator.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/troubleshooting/metrics-generator.md

Co-authored-by: Kim Nylander <[email protected]>

* added more details

Signed-off-by: Joe Elliott <[email protected]>

* Update docs/sources/tempo/operations/troubleshooting/metrics-generator.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/troubleshooting/metrics-generator.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/troubleshooting/metrics-generator.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/troubleshooting/metrics-generator.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/troubleshooting/metrics-generator.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/troubleshooting/metrics-generator.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/troubleshooting/metrics-generator.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/troubleshooting/metrics-generator.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/troubleshooting/metrics-generator.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/troubleshooting/metrics-generator.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/troubleshooting/metrics-generator.md

Co-authored-by: Kim Nylander <[email protected]>

* review notes

Signed-off-by: Joe Elliott <[email protected]>

---------

Signed-off-by: Joe Elliott <[email protected]>
Co-authored-by: Kim Nylander <[email protected]>
(cherry picked from commit 5e51eb7)

Co-authored-by: Joe Elliott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knylander-grafana knylander-grafana knylander-grafana approved these changes

@zalegrala zalegrala zalegrala approved these changes

@yvrhdn yvrhdn yvrhdn approved these changes

@annanay25 annanay25 Awaiting requested review from annanay25

@mdisibio mdisibio Awaiting requested review from mdisibio mdisibio is a code owner

@mapno mapno Awaiting requested review from mapno mapno is a code owner

@electron0zero electron0zero Awaiting requested review from electron0zero electron0zero is a code owner

@ie-pham ie-pham Awaiting requested review from ie-pham ie-pham is a code owner

@stoewer stoewer Awaiting requested review from stoewer stoewer is a code owner

Assignees
No one assigned
Labels
backport release-v2.2 type/docs Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joe-elliott @yvrhdn @zalegrala @knylander-grafana