chore: bump go module path #3926
Conversation
davidgiga1993
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno,
yvrhdn,
zalegrala,
electron0zero,
ie-pham and
stoewer
as code owners
|
|
davidgiga1993
force-pushed
the
bump-module-path
branch
from
924423f
to
bef502b
Compare
# Conflicts: # integration/bench/load_test.go # integration/e2e/api_test.go # integration/e2e/backend/backend.go # integration/e2e/compression_test.go # integration/e2e/cross_cluster_reads_test.go # integration/e2e/e2e_test.go # integration/e2e/encodings_test.go # integration/e2e/https_test.go # integration/e2e/limits_test.go # integration/e2e/metrics_generator_test.go # integration/e2e/multi_tenant_test.go # integration/e2e/overrides_test.go # integration/e2e/query_plugin_test.go # integration/e2e/receivers_test.go # integration/e2e/serverless/serverless_test.go # integration/poller/poller_test.go # modules/frontend/combiner/common_test.go # modules/frontend/pipeline/collector_http.go # modules/generator/instance.go # modules/generator/instance_test.go # pkg/traceql/util.go
|
I just pulled the latest changes on main into this. As a merge conflict will arise from every new change on main it would be great if someone could provide feedback for this change, thanks! |
|
Hi @davidgiga1993. Does this show up because you are vendoring Tempo somewhere? I remember seeing the Loki team made this change as you point out, but didn't follow the results closely to know how it went. |
|
@zalegrala yes we're trying to use Tempo as package for a custom reverse proxy to parse the AST of the query. We're doing the same thing with Prometheus and Loki (which can be consumed as a dependency) |
|
This change seems reasonable to me. We hesitate because this will cause some additional work for us internally. However, it might be nice to get this in before 2.6. If this can get updated I can help review early next week. |
I've resolved the conflicts |
|
And again |
|
This PR has been automatically marked as stale because it has not had any activity in the past 60 days. |
What this PR does:
Changes the module path to match the major version, this resolves
go getnot working.This change was based upon the changes required for the v3 loki release
Which issue(s) this PR fixes:
Fixes #3817
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]