Experiment with string interning on BlockMeta #3931
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zalegrala
force-pushed
the
blockMetaStringIntern
branch
from
150532f
to
cf13180
Compare
zalegrala
commented
Aug 5, 2024
zalegrala
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno,
kvrhdn,
electron0zero,
ie-pham and
stoewer
as code owners
joe-elliott
reviewed
Aug 5, 2024
joe-elliott
reviewed
Aug 5, 2024
zalegrala
force-pushed
the
blockMetaStringIntern
branch
from
c48ee2e
to
82789ca
Compare
zalegrala
force-pushed
the
blockMetaStringIntern
branch
from
82789ca
to
188cab5
Compare
There was a problem hiding this comment.
I know we are discussing moving from json to proto but this lib here claims to be more performant https://github.com/json-iterator/go
We already use it in some places
zalegrala
commented
Aug 8, 2024
| @@ -89,6 +90,28 @@ type CompactedBlockMeta struct { | |||
| CompactedTime time.Time `json:"compactedTime"` | |||
| } | |||
|
|
|||
| func (b *CompactedBlockMeta) UnmarshalJSON(data []byte) error { | |||
There was a problem hiding this comment.
I experimented with the alias here as well, but the embedding throws it off. I think we keep the custom change without the alias here unless I missed something obvious.
|
We're not seeing the improvements we want to see here. The extra allocations are making us rethink our approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Here is a bit of experiment to see if we can reduce the size of memory that the poller consumes.
internpackage which will intern a stringUnmarshalJsononBlockMetaandCompactedBlockMetaWhich issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]