Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native histograms processor replacement enum #3938

Merged

Conversation

zalegrala
Copy link
Contributor

What this PR does:

Plumb an enum into the native histograms and update overrides.

As a follow up to #3923

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@zalegrala zalegrala marked this pull request as draft August 5, 2024 20:13
@zalegrala
Copy link
Contributor Author

Taking back to draft while I work out the CI.

@zalegrala zalegrala marked this pull request as ready for review August 6, 2024 13:11
Copy link
Member

@yvrhdn yvrhdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change rippled out a lot more than I expected but nice cleanup!

modules/generator/processor/servicegraphs/servicegraphs.go Outdated Show resolved Hide resolved
cmd/tempo/app/overrides_validation.go Outdated Show resolved Hide resolved
@zalegrala zalegrala merged commit e33d407 into grafana:main Aug 14, 2024
16 checks passed
@zalegrala zalegrala deleted the nativeHistogramsProcessorReplacementEnum branch August 14, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants