Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instrumentation.md to correct Jaeger typos #3940

Closed
wants to merge 2 commits into from
Closed

Conversation

wcall
Copy link

@wcall wcall commented Aug 6, 2024

Found two misspelled Jaegar and corrected them to Jaeger.

What this PR does:

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Found two misspelled Jaegar and corrected then to Jaeger.
@CLAassistant
Copy link

CLAassistant commented Aug 6, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ knylander-grafana
❌ wcall
You have signed the CLA already but the status is still pending? Let us recheck it.

@electron0zero electron0zero enabled auto-merge (squash) August 6, 2024 04:13
@zalegrala
Copy link
Contributor

Hi @wcall, would you mind signing the CLA so we can accept this change?

Copy link
Contributor

@knylander-grafana knylander-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for catching these!

@knylander-grafana knylander-grafana self-assigned this Aug 8, 2024
@knylander-grafana knylander-grafana added type/docs Improvements or additions to documentation backport release-v2.5 labels Aug 8, 2024
Copy link
Contributor

github-actions bot commented Aug 8, 2024

This PR must be merged before a backport PR will be created.

@knylander-grafana
Copy link
Contributor

Thank you for your fixes! I can't merge your PR unless the CLA is signed. I've recreated your chagges in this PR: #4015

auto-merge was automatically disabled August 27, 2024 21:44

Pull request was closed

Copy link
Contributor

This PR must be merged before a backport PR will be created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-v2.5 type/docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants