Begin converting TenantIndex, BlockMeta, CompactedBlockMeta to proto #3946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zalegrala
commented
Aug 7, 2024
| string data_encoding = 14; | ||
| uint32 bloom_shard_count = 15; | ||
| uint32 footer_size = 16; | ||
| repeated tempopb.DedicatedColumn dedicated_columns = 17; |
There was a problem hiding this comment.
This causes the encodings to require updates in lots of ways. I'm not sure how to reduce scope.
There was a problem hiding this comment.
Perhaps this could be moved off the blockmeta object. Need to check where this is consumed, which could be too many places for us to want here.
There was a problem hiding this comment.
Oof. Yes. This is the sticking point. We already have a dedicated columns proto in /pkg/tempopb.
Wdyt about moving BlockMeta and Dedicated Columns proto to /pkg/tempopb/backend?
Then the messages in /pkg/tempopb could easily reference them and that would consolidate all of backend and request proto? or is that just going to cause a bigger mess?
zalegrala
force-pushed
the
tenantIndexProto
branch
2 times, most recently
from
501aa7c
to
baff6f0
Compare
zalegrala
force-pushed
the
tenantIndexProto
branch
from
3d37978
to
37abe3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]